Skip to content

Rocm/Cuda unit test improvement#95

Merged
smuzaffar merged 1 commit intoscramv3from
alpaka-tests
Apr 19, 2023
Merged

Rocm/Cuda unit test improvement#95
smuzaffar merged 1 commit intoscramv3from
alpaka-tests

Conversation

@smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Apr 18, 2023 •
edited
Loading

Various unit tests improvements

  • Unit tests with direct rocm or alpaka dependency (with rocm backend enabled)
    • Run tests if alpakaIsEnabledROCmAsync command is either missing or runs successfully
  • Unit tests with direct cuda or alpaka dependency (with cuda backend enabled)
    • Run tests if alpakaIsEnabledCudaAsync command is either missing or runs successfully

If USER_UNIT_TESTS=<tools> is set then alpakaIsEnabledX check is ignored and scram force runs unit tests which directory depend on <tools> e.g.

  • USER_UNIT_TESTS=rocm scram build runtests will run all tests which directly depend on rocm or alpaka-rocm.
  • USER_UNIT_TESTS=cuda scram build runtests will run all tests which directly depend on cuda or alpaka-cuda.
  • USER_UNIT_TESTS="cuda serial" scram build runtests will run all tests which directly depend on cuda , alpaka-cuda or aplaka-serial.
  • USER_UNIT_TESTS="boost" scram build runtests will run all tests which directly depend on boost

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 18, 2023

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch scramv3.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Apr 18, 2023

test parameters:

  • full_cmssw = true

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Apr 18, 2023

please test

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Apr 18, 2023

here are some examples

  • Using USER_UNIT_TESTS to run only selected unit tests
> USER_UNIT_TESTS=rocm scram b runtests
Skip    0s ... x/y/Alpaka1CudaAsync (Not a rocm alpaka-rocm type test)
Pass    1s ... x/y/Alpaka1ROCmAsync
Skip    0s ... x/y/Alpaka1SerialSync (Not a rocm alpaka-rocm type test)
Skip    0s ... x/y/Boost1 (Not a rocm alpaka-rocm type test)
Skip    0s ... x/y/Cuda1 (Not a rocm alpaka-rocm type test)
Pass    0s ... x/y/Rocm1
Skip    0s ... x/y/Root1 (Not a rocm alpaka-rocm type test)
> USER_UNIT_TESTS=cuda scram b runtests
Pass    1s ... x/y/Alpaka1CudaAsync
Skip    0s ... x/y/Alpaka1ROCmAsync (Not a cuda alpaka-cuda type test)
Skip    0s ... x/y/Alpaka1SerialSync (Not a cuda alpaka-cuda type test)
Skip    0s ... x/y/Boost1 (Not a cuda alpaka-cuda type test)
Pass    0s ... x/y/Cuda1
Skip    0s ... x/y/Rocm1 (Not a cuda alpaka-cuda type test)
Skip    0s ... x/y/Root1 (Not a cuda alpaka-cuda type test)
> USER_UNIT_TESTS="root boost" scram b runtests
Skip    0s ... x/y/Alpaka1CudaAsync (Not a root boost type test)
Skip    0s ... x/y/Alpaka1ROCmAsync (Not a root boost type test)
Skip    0s ... x/y/Alpaka1SerialSync (Not a root boost type test)
Pass    0s ... x/y/Boost1
Skip    0s ... x/y/Cuda1 (Not a root boost type test)
Skip    0s ... x/y/Rocm1 (Not a root boost type test)
Pass    0s ... x/y/Root1
  • Default unit tests on node with Nvidia GPU where alpakaIsEnabledCudaAsync runs successfully and alpakaIsEnabledROCmAsync fails
> scram b runtests
Pass    0s ... x/y/Alpaka1CudaAsync
Skip    0s ... x/y/Alpaka1ROCmAsync (Failed to run alpakaIsEnabledROCmAsync)
Pass    0s ... x/y/Alpaka1SerialSync
Pass    0s ... x/y/Boost1
Pass    0s ... x/y/Cuda1
Skip    0s ... x/y/Rocm1 (Failed to run alpakaIsEnabledROCmAsync)
Pass    0s ... x/y/Root1
  • Default unit tests on node with AMD GPU where alpakaIsEnabledROCmAsync runs successfully and alpakaIsEnabledCudaAsync fails
> scram b runtests
Skip    0s ... x/y/Alpaka1CudaAsync (Failed to run alpakaIsEnabledCudaAsync)
Pass    0s ... x/y/Alpaka1ROCmAsync
Pass    0s ... x/y/Alpaka1SerialSync
Pass    0s ... x/y/Boost1
Skip    0s ... x/y/Cuda1 (Failed to run alpakaIsEnabledCudaAsync)
Pass    0s ... x/y/Rocm1
Pass    0s ... x/y/Root1

@smuzaffar smuzaffar mentioned this pull request Apr 18, 2023
Open
2 tasks
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 18, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c44bb0/32023/summary.html
COMMIT: b69f8d9
CMSSW: CMSSW_13_1_X_2023-04-18-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw-config/95/32023/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c44bb0/32023/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c44bb0/32023/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 174 lines from the logs
  • Reco comparison results: 1684 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3459877
  • DQMHistoTests: Total failures: 7674
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3452181
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Apr 19, 2023

+externals

@smuzaffar smuzaffar merged commit eab92a9 into scramv3 Apr 19, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 19, 2023

This pull request is fully signed and it will be integrated in one of the next scramv3 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

smuzaffar added a commit to cms-sw/cmsdist that referenced this pull request Apr 19, 2023
@smuzaffar
[BuildRules] Rocm/Cuda unit test improvement
80f3f4e 
see cms-sw/cmssw-config#95
@smuzaffar smuzaffar mentioned this pull request Apr 19, 2023
Merged
@smuzaffar smuzaffar mentioned this pull request Nov 6, 2023
Merged
@smuzaffar smuzaffar deleted the alpaka-tests branch March 28, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

externals-approved fully-signed orp-pending tests-approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@smuzaffar @cmsbuild